Skip to content

Conversation

clay53
Copy link
Contributor

@clay53 clay53 commented Feb 9, 2025

No description provided.

@clay53 clay53 marked this pull request as ready for review April 11, 2025 20:59
@clay53 clay53 requested a review from joyliu-q April 11, 2025 20:59
@clay53
Copy link
Contributor Author

clay53 commented Aug 29, 2025

merge if you dare

@clay53 clay53 requested review from ryantanen and removed request for joyliu-q August 29, 2025 22:36
Copy link

@ryantanen ryantanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did you test in the production emulation thing you made?

@@ -1,7 +1,7 @@
#!/bin/bash

# Django Migrate
/usr/bin/python3 /app/manage.py migrate --noinput
python3 manage.py migrate --noinput ||

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no uv here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default python3 should be the python3 installed uv. Which, I think it is because otherwise the deps wouldn't resolve

@ryantanen ryantanen merged commit 1dd70a7 into master Sep 19, 2025
7 checks passed
@ryantanen ryantanen deleted the uv-migration branch September 19, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants